Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Add failing test for linking @ in @names via autoLinkWithJSON #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timhaines
Copy link

If you use autoLinkWithJSON, only 'name' of @name is linked. The @ is not linked. According to Twitter's display requirements, the @ should be linked too.

@timhaines
Copy link
Author

image

@jakl
Copy link
Contributor

jakl commented May 5, 2014

An intermediary fix is to use

twtxt.autoLink("My @name", { usernameIncludeSymbol: true })

And we can make this option the default going forward.

@timhaines
Copy link
Author

autoLinkWithJSON("my @name", entities, { usernameIncludeSymbol: true }) works too. Awesome. This is a non-issue for us now, but yeah, it seems like updating the defaults to match your display requirements would make sense.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants