Currency instances #4564
Open
Currency instances #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Feb 21, 2024
satorg
reviewed
Feb 22, 2024
kernel/src/main/scala/cats/kernel/instances/CurrencyInstances.scala
Outdated
Show resolved
Hide resolved
satorg
reviewed
Feb 22, 2024
Comment on lines
+33
to
+36
| implicit private val arbitraryCurrency: Arbitrary[Currency] = Arbitrary( | ||
| Gen.oneOf(Currency.getAvailableCurrencies().asScala) | ||
| ) | ||
| implicit private val cogenCurrency: Cogen[Currency] = Cogen[String].contramap(_.getCurrencyCode()) |
There was a problem hiding this comment.
Perhaps, it would not hurt if we put these instances into cats.laws.discipline.arbitrary to make them available for everyone.
There was a problem hiding this comment.
I'm wrapping my head around the dependency graph here. Doesn't the laws module depend on this one? If we want to add these instances to kernel-laws, is there a way to add jvm-only code without moving too many files (kernel-laws is defined as CrossType.Pure)? Sorry not very used to cross compilation.
massimosiani
commented
Feb 23, 2024
| @@ -48,4 +49,8 @@ private[cats] object scalaVersionSpecific { | |||
| that: T | |||
| )(implicit w1: A => TraversableLike[El1, Repr1], w2: T => IterableLike[El2, Repr2]) = (a, that).zipped | |||
| } | |||
|
|
|||
| implicit class setExtension[A](private val a: A) extends AnyVal { | |||
| def asScala(s: java.util.Set[A]): mutable.Set[A] = `set asScala`(s) | |||
There was a problem hiding this comment.
@armanbilge any better idea?
|
Is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4562.
I followed the steps outlined here #3910 (comment), there's no
Currencyin scala js/native tough.