Add an option to disable errorVerbose #1487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantv
reviewed
Feb 4, 2025
zapcore/field.go
Outdated
| Integer int64 | ||
| String string | ||
| Interface interface{} | ||
| DisableErrorVerbose bool |
There was a problem hiding this comment.
We avoid adding new struct fields to the Field type for performance reasons, as the struct is passed as a value.
We could add a new FieldType to indicate an error that should only have the message included, though that could have backwards compatibility concerns with some encoders.
There was a problem hiding this comment.
I appreciate your feedback. I will create a new type with error field and DisableErrorVerbose field.
makotonakai
force-pushed
the
turn-off-error-verbose
branch
2 times, most recently
from
1200ec6 to
d3399cc
Compare
|
Sorry for bothering you. Could you review my PR, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
disableErrorVerboseoption toLoggertype.This option allows users to disable the output of error verbose when they use pkg/errors.
Closes #650 #1168