Skip to content

Commit

Permalink
Rename W16_lab05.5.md to W16_lab05.md
Browse files Browse the repository at this point in the history
  • Loading branch information
natashalee committed Mar 10, 2016
1 parent e644e83 commit 9aba1ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion W16_lab05.5.md → W16_lab05.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ H. 1. One more issue that can be added is "Add Tests" as the testing suite is no

I. The code is organized into three main java classes: UCSBLecture, UCSBSection, and UCSBCirriculumSearch. It is fairly clear on how these three classes work together. All the files have sufficient comments in order to quickly grasp what the code does ie: "When searching for courses, the HTTP POST method must be used---this method helps to encode the HTML Form parameters properly (using URLEncoding)." However, there are still some "TODO:" comments, when they seem to have already been done. The code is easy to read as the writers used standard coding style along with coming up with good names/labels for their functions and variables. To get a programmer up to speed, I would simply tell him/her how the classes interact with each other and which functions each class serves. For example, the UCSBCirriculumSearch class scrapes through the provided URL in order to get the desired data we need to find out which courses there are with the provided search critera. Next, the UCSBLecture class takes in that data to create an object that represents a single course's lecture information while the UCSBSection class does the same thing, just it takes in the information for a classs section.

J. The testing is not extensive. For example, UCSBSectionTest is a completely new file with no tests written other than a comment "TODO:". In addition, UCSBCirriculumSearchTest has only a single assert call; thus, it only has one test going for it. On the other hand, UCSBLectureTest has a much more extensive testing suite compared to the others. However, it seems that the ToString function only has a single test case. One more thing of note, is that the tests that are there are cover JUNIT, but there are definitely many oppurtinities to expand the test coverage. To do so, we could initiate more variables and objects to run the tests. In addition, for SectionTest, we have to write all the tests as it has none. For this, we could test its setters and getters along with the functions toString and equals in the same vain as before.
J. The testing is not extensive. For example, UCSBSectionTest is a completely new file with no tests written other than a comment "TODO:". In addition, UCSBCirriculumSearchTest has only a single assert call; thus, it only has one test going for it. On the other hand, UCSBLectureTest has a much more extensive testing suite compared to the others. However, it seems that the ToString function only has a single test case. One more thing of note, is that the tests that are there are cover JUNIT, but there are definitely many oppurtinities to expand the test coverage. To do so, we could initiate more variables and objects to run the tests. In addition, for SectionTest, we have to write all the tests as it has none. For this, we could test its setters and getters along with the functions toString and equals in the same vain as before.

0 comments on commit 9aba1ea

Please sign in to comment.