Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added triang and kappa as iteration variables #3563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ym1906
Copy link
Collaborator

@ym1906 ym1906 commented Feb 28, 2025

Description

Add kappa and triang as iteration variables

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.19%. Comparing base (8966166) to head (3365b85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3563   +/-   ##
=======================================
  Coverage   31.19%   31.19%           
=======================================
  Files          83       83           
  Lines       19936    19936           
=======================================
  Hits         6220     6220           
  Misses      13716    13716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ym1906
Copy link
Collaborator Author

ym1906 commented Feb 28, 2025

@timothy-nunn Would you mind reviewing this, before you begin converting it? 🙏

@ym1906 ym1906 requested a review from timothy-nunn February 28, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add elongation (kappa) and triangularity (triang) as iteration variables
2 participants