Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/26 publish pypy on tag push #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dalauren
Copy link

@dalauren dalauren commented Mar 5, 2024

closes #26

@ultrabug
Copy link
Owner

ultrabug commented Mar 5, 2024

Can you explain why you choose not to do that in a separate file? I'm interested to know :)

@dalauren
Copy link
Author

dalauren commented Mar 5, 2024

Oh, you can do that in separate files! I didn't know. Actually, I've never used GitHub Actions, so I thought it was supposed to be in the same file as all the other actions. When researching how to trigger an action when a tag is pushed, this if option seemed like the right way to do it.

Is it okay to leave it in the same file? I'm not sure if separating both actions is necessary.

@ultrabug
Copy link
Owner

ultrabug commented Mar 7, 2024

Is it okay to leave it in the same file? I'm not sure if separating both actions is necessary.

It's not per se BUT it's useful because you get a separate build action instead of having everything in one

I'd like to keep it consistent with my other projects which is why I linked a working example : https://github.com/ultrabug/mkdocs-static-i18n/blob/main/.github/workflows/deploy-release.yml

Sorry

@dalauren
Copy link
Author

dalauren commented Mar 7, 2024

No worries, i'll make the changes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI : add workflow to deploy to PyPi on tag push
2 participants