Updated import module #6817
Merged
Updated import module #6817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofietoft
reviewed
Jan 24, 2025
| {% hint style="info" %} | ||
| Optionally you can use `--legacy-peer-deps` in the installation command to avoid installing Umbraco´s sub-dependencies like TinyMCE and Monaco Editor:\ | ||
| `npm install --legacy-peer-deps -D @umbraco-cms/backoffice` | ||
| * Ensure that you install the version relevant to your Umbraco installation. You can find the appropriate version on the [@umbraco-cms/backoffice npm page](https://www.npmjs.com/package/@umbraco-cms/backoffice). Alternatively, you can manually update the version in your `package.json` file to match your setup. |
There was a problem hiding this comment.
I think generally we should try to add warnings/notes related to checking specific versions, before the steps to install.
Otherwise, people might install the wrong thing, only to read this note afterwards 😅
Also, the bullets are quite long and contain a lot of info. Consider if it makes sense to just add the info to a paragraph.
There was a problem hiding this comment.
Makes sense. I've tried to incorporate your review comments. Also, I made some slight changes to other steps to ensure proper flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue #6797
Also, while testing the article, I had to bump the backoffice version. I added that info in the Vite Package Setup article.
Type of suggestion
Product & version (if relevant)
CMS v15
Deadline (if relevant)
When should the content be published?