Tidy up duplicated method

unboxed · Feb 18, 2025 · 11a756a · 11a756a
1 parent cd19043
commit 11a756a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/app/controllers/planning_applications/review/base_controller.rb b/app/controllers/planning_applications/review/base_controller.rb
@@ -39,6 +39,10 @@ def redirect_failed_create_error(error)
         redirect_to planning_application_review_tasks_path(@planning_application), alert: Array.wrap(error).to_sentence
       end
 
+      def redirect_to_review_tasks
+        redirect_to planning_application_review_tasks_path(@planning_application)
+      end
+
       def render_review_tasks
         set_planning_application_constraints
         set_neighbour_review

diff --git a/app/controllers/planning_applications/review/cil_liability_controller.rb b/app/controllers/planning_applications/review/cil_liability_controller.rb
@@ -47,10 +47,6 @@ def activity_information
         end
       end
 
-      def redirect_to_review_tasks
-        redirect_to planning_application_review_tasks_path(@planning_application)
-      end
-
       def cil_feature?
         @planning_application.application_type.cil?
       end

diff --git a/app/controllers/planning_applications/review/considerations_controller.rb b/app/controllers/planning_applications/review/considerations_controller.rb
@@ -45,10 +45,6 @@ def review_params
           .permit(:action, :comment, :review_status)
           .merge(reviewer: current_user, reviewed_at: Time.current)
       end
-
-      def redirect_to_review_tasks
-        redirect_to planning_application_review_tasks_path(@planning_application)
-      end
     end
   end
 end
diff --git a/app/controllers/planning_applications/review/informatives_controller.rb b/app/controllers/planning_applications/review/informatives_controller.rb
@@ -48,10 +48,6 @@ def review_params
           .merge(reviewer: current_user, reviewed_at: Time.current)
       end
 
-      def redirect_to_review_tasks
-        redirect_to planning_application_review_tasks_path(@planning_application)
-      end
-
       def informatives_not_started?
         @review.not_started?
       end