Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: husky commit hooks #36

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: husky commit hooks #36

wants to merge 8 commits into from

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Aug 26, 2024

Summary

Commit messages are linted to follow the Conventional Config format, if they do not the commit fails. JavaScript and Vue files are linted before commiting, if they have linting warnings or errors the commit fails. Details of why a commit failed are logged in the console. README has been updated to include repo setup steps.

Dependencies

  • husky
  • commitlint and @commitlint/config-conventional

Technical Details

Linting JS and Vue files has been implemented in the site package only. Further discussion is needed to determine how to handle linting in zero-core and I don't want to mess with docs while it's still being set up but it should follow the same pattern as site.

Resolutions

  • Ticket link: Completes UL-256, UL-299
  • Code documented
  • Test cases written

@tikagan tikagan self-assigned this Aug 26, 2024
@tikagan tikagan changed the title Feat husky feat: husky commit hooks Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants