-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change metacrate description for crates.io #5215
Conversation
components/icu/Cargo.toml
Outdated
@@ -4,7 +4,7 @@ | |||
|
|||
[package] | |||
name = "icu" | |||
description = "International Components for Unicode" | |||
description = "ICU4X Project: Unicode Internationalization Library for Rust" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"for Rust" is also not specific enough imho. rust-icu
is "for Rust"
description = "ICU4X Project: Unicode Internationalization Library for Rust" | |
description = "International Components for Unicode, written in pure Rust (ICU4X)" |
"ICU4X" should also be added as a keyword.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note this is icu
; icu_capi
could have a different description.
How's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware that this is icu
, what does icu_capi
have to do with this?
Also update the description of the icu4x
crate to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part about being "in Rust" is relevant because this is the Rust API. icu_capi
should emphasize the non-Rust APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want it to say "in Rust" to emphasize that the whole thing is written in Rust (safe), as opposed to being bindings to C++ (unsafe). That a Rust crates exposes a Rust API is assumed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think adding icu4x
as a keyword is as important as adding it to the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly agree with adding keywords, but let's not scope-creep this PR
I think it will be a better use of time to just set aside 10 minutes of meeting time to wordsmith this together, rather than throwing drafts back and forth. |
Agreed description of the Description of the For comparison,
Decision:
|
I made a new issue to follow-up on changing the |
This description shows up on our crates.io page and in search results:
https://crates.io/crates/icu
It doesn't say anything about ICU4X. I was working with @FrankYFTang today who thought we hadn't uploaded anything to crates.io because it wasn't evident in search results that the crate named
icu
is ICU4X.This is especially important since the second search result is @filmil's
rust_icu
, which is ICU4C (and it says so in its description).