Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fixtures to neo datetime #5259

Closed
wants to merge 1 commit into from
Closed

Conversation

sffc
Copy link
Member

@sffc sffc commented Jul 17, 2024

For posterity, here is the final head-to-head benchmark before I delete it for the old formatter:

datetime/datetime_components
                        time:   [486.25 µs 489.23 µs 493.44 µs]
Found 14 outliers among 100 measurements (14.00%)
  8 (8.00%) low mild
  2 (2.00%) high mild
  4 (4.00%) high severe

datetime/datetime_lengths
                        time:   [40.602 µs 40.683 µs 40.769 µs]
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high severe

datetime/neoneo/datetime_lengths
                        time:   [34.485 µs 34.574 µs 34.689 µs]
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high severe

I never added the components bag benchmarks to the neo formatter; I will migrate them directly to semantic skeleta.

@sffc
Copy link
Member Author

sffc commented Sep 23, 2024

Obsoleted by other PRs. The latest bench numbers are here: #1317 (comment)

@sffc sffc closed this Sep 23, 2024
@sffc sffc deleted the fixture-migrate branch September 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant