Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Enum #1798

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Support Enum #1798

merged 4 commits into from
Sep 22, 2024

Conversation

gab23r
Copy link
Contributor

@gab23r gab23r commented Sep 2, 2024

Fixes #1768, #1767

Not really familiar to the codebase, so review carefully

Signed-off-by: gabriel <[email protected]>
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.20%. Comparing base (812b2a8) to head (c3a3715).
Report is 144 commits behind head on main.

Files with missing lines Patch % Lines
pandera/engines/polars_engine.py 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   94.28%   93.20%   -1.08%     
==========================================
  Files          91      120      +29     
  Lines        7013     9173    +2160     
==========================================
+ Hits         6612     8550    +1938     
- Misses        401      623     +222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy
Copy link
Collaborator

thanks @gab23r ! reviewing this now... in the mean time, you can run the pre-commit hooks to fix linter

@apsocarras
Copy link

For what it's worth, Polars still has Enum marked as an unstable feature:

https://docs.pola.rs/api/python/stable/reference/api/polars.datatypes.Enum.html#polars.datatypes.Enum

Thanks for the small patch -- likewise too unfamiliar with the codebase to review it, but I may try it out in some analysis workflows.

@cosmicBboy
Copy link
Collaborator

Thanks for the contribution @gab23r !

@cosmicBboy cosmicBboy merged commit 90633f2 into unionai-oss:main Sep 22, 2024
144 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polars Enum does not work for Polars verion >=1.0.0
3 participants