-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove revert commits from changelog #65
Open
KennethTrecy
wants to merge
13
commits into
unjs:main
Choose a base branch
from
KennethTrecy:revert_resolver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
===========================================
+ Coverage 68.63% 82.84% +14.20%
===========================================
Files 9 5 -4
Lines 880 542 -338
Branches 81 78 -3
===========================================
- Hits 604 449 -155
+ Misses 276 93 -183
|
KennethTrecy
force-pushed
the
revert_resolver
branch
from
March 4, 2023 02:57
805d93d
to
a14d749
Compare
KennethTrecy
force-pushed
the
revert_resolver
branch
from
March 4, 2023 03:47
2e11919
to
09f30cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
This PR slightly modifies
parseGitCommit()
and related types to extract the commits that has been reverted. Then,filterCommits()
removes the commits that revert others or has been reverted. However, the commit that does the reversion, and the commits that would be reverted should be in the current version only. See the following scenarios below.For example, we have the following log:
In this example, commit
abc123
reverts the commitdef456
. Therefore, both of them would not be present in the resulting change log set. Only the fourth commit would show.However, if a commit reverts a commit from previous version, it would not remove it.
In this second example, third, fourth, and fifth commit would be shown in the change log set.
I added tests to ensure the implementation is working. Let me know if there is something I could improve in this PR. Thank you.