Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cors): fix acao header #870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cors): fix acao header #870

wants to merge 1 commit into from

Conversation

aaharu
Copy link
Contributor

@aaharu aaharu commented Aug 26, 2024

resolves #355

@aaharu aaharu requested a review from pi0 as a code owner August 26, 2024 09:16
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (a58d7c9) to head (eddcc5c).
Report is 172 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   77.83%   78.76%   +0.93%     
==========================================
  Files          47       43       -4     
  Lines        4286     3292     -994     
  Branches      611      793     +182     
==========================================
- Hits         3336     2593     -743     
+ Misses        933      696     -237     
+ Partials       17        3      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Aug 29, 2024

Can you please add a regression test?

@aaharu
Copy link
Contributor Author

aaharu commented Sep 17, 2024

It's going to be a conflict, so I'll work on it after #856.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS issue in creating origin headers
2 participants