feat(rspack): support buildStart #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
reviewed
Jul 2, 2023
src/rspack/index.ts
Outdated
| compiler.modifiedFiles.forEach(file => | ||
| promises.push( | ||
| Promise.resolve( | ||
| plugin.watchChange!.call(context, file, { |
There was a problem hiding this comment.
The returning value of watchChange is void. Why do need Promise.resolve here?
There was a problem hiding this comment.
The watchChange is indeed useless, I have already removed it.
Wyatex
force-pushed
the
main
branch
2 times, most recently
from
16a127d
to
fa502ba
Compare
sxzz
reviewed
Jul 3, 2023
sxzz
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildStart looks supported in the readme, but it doesn't actually support that. So I copied it directly from the webpack and tried it and it worked.