Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fonts #48

Closed
wants to merge 2 commits into from
Closed

Update fonts #48

wants to merge 2 commits into from

Conversation

d2dyno1
Copy link

@d2dyno1 d2dyno1 commented Jul 27, 2024

GitHub Issue (If applicable): #

PR Type

Update some fonts mentioned in #47
Closes #47

What is the current behavior?

image

What is the new behavior?

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2024

CLA assistant check
All committers have signed the CLA.

@d2dyno1
Copy link
Author

d2dyno1 commented Jul 27, 2024

I've hand-exported and imported some icons from Segoe Fluent Icons directly into Uno fluent icons.
I haven't found a way to export .eot and .css files, so they are not included in this PR. (I can share my .sfd project if anyone is willing to help 🙂)

@d2dyno1
Copy link
Author

d2dyno1 commented Jul 28, 2024

Tagging members for visibility: @MartinZikmund @jeromelaban

@MartinZikmund
Copy link
Member

@d2dyno1 thanks for the PR, but currently we are using icomoon to generate the font - @NVLudwig has those source files, so he would be able to update the font and generate the proper files, if you upload the SVGs you have used here

@NVLudwig
Copy link

@d2dyno1 Happy to update that for you, could you also include the unicode for the icon(s) you added?

@agneszitte
Copy link
Contributor

@MartinZikmund, @NVLudwig as #50 is now merged, what is the status for this current PR please?

@d2dyno1
Copy link
Author

d2dyno1 commented Sep 13, 2024

Thanks for the update! I think this can be closed now...

@d2dyno1 d2dyno1 closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing glyphs in Fluent icons
5 participants