Cleanup #9
Merged
Cleanup #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSprenger
commented
Dec 29, 2024
| }; | ||
|
|
||
| // Why? | ||
| can.set_protocol_exception_handling(false); |
There was a problem hiding this comment.
I think this is left over from hydra since I wanted to dump CAN messages as fast as possible and this was a performance improvement.
BLM16
approved these changes
Dec 29, 2024
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
boards/pressureandboards/straindirectories, primarily involving the removal of various modules and dependencies. The most important changes include the removal of theCargo.tomlfiles, theAdcManager,CanCommandManager,CanDataManager,RadioDevice,RadioManager,DataManager, andCOM_IDdefinitions.Dependency and configuration removals:
boards/pressure/Cargo.toml: Removed the entire file, including package metadata and dependencies.boards/strain/Cargo.toml: Removed the entire file, including package metadata and dependencies.Module removals:
boards/pressure/src/adc_manager.rs: Removed theAdcManagerstruct and its implementation.boards/pressure/src/communication.rs: Removed theCanCommandManager,CanDataManager,RadioDevice, andRadioManagerstructs and their implementations.boards/pressure/src/data_manager.rs: Removed theDataManagerstruct and its implementation.boards/pressure/src/types.rs: Removed theCOM_IDstatic variable definition.boards/pressure/tests/sd.rs: Removed the entire test file for the SD card manager.boards/strain/src/adc_manager.rs: Removed theAdcManagerstruct and its implementation.