-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Workflow Logs API docs #391
base: main
Are you sure you want to change the base?
Conversation
--- | ||
|
||
<Warning> | ||
The flat events provide a more detailed version of the [List Workflow Events API](/workflow/rest/runs/event-logs). If you need an overview of a workflow run, that API is more useful, as it returns grouped and processed data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link needs to be updated.
/workflow/rest/runs/event-logs
-> /workflow/rest/runs/runs
</ParamField> | ||
|
||
<ParamField query="state" type="string"> | ||
Filter logs by [state](/qstash/howto/debug-logs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the states of the Workflow's right. Not the messages.
I guess we need to remove the link and mention the differnce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, I entered the comment on the wrong API.
This API for flat events. That means, user can enter message events and also RUN_STARTED
, WAITER_ADDED
etc. So the linked doc is still not enough.
</ParamField> | ||
|
||
<ParamField query="state" type="string"> | ||
Filter workflow runs by [state](/qstash/howto/debug-logs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the states of the Workflow's right. Not the messages.
I guess we need to remove the link and mention that these can only be RUN_STARTED/RUN_SUCCESS etc.
Logs API allows users to fetch details about their workflow runs.