Add validation to Redis databases' regions #42
+33
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,149 +16,152 @@ func ResourceDatabase() *schema.Resource { | |||
| UpdateContext: resourceDatabaseUpdate, | |||
| DeleteContext: resourceDatabaseDelete, | |||
| Schema: map[string]*schema.Schema{ | |||
| "database_id": &schema.Schema{ | |||
There was a problem hiding this comment.
Note
I removed the redundant &schema.Schema. There are other redundant declaration in other files but I limited the scope of the change to this file.
KeisukeYamashita
force-pushed
the
add-validation-func-to-region
branch
from
8d5d76c
to
72d1324
Compare
Signed-off-by: KeisukeYamashita <[email protected]>
KeisukeYamashita
force-pushed
the
add-validation-func-to-region
branch
from
72d1324
to
bcfb761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The user can quickly see the error message during t
erraform planinstead of encountering the issue when applying the changes.