feat(PositionsGrid): remove previous searched item on next search #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upupming
requested changes
Aug 9, 2022
| @@ -48,6 +48,9 @@ export const PositionsGrid: React.FC<PositionsGridProps> = ({ positions, }) => { | |||
| ref={searchRef} | |||
| onKeyDown={(e) => { | |||
| if (e.key === 'Enter') { | |||
| if (document.querySelector('#inputText')?.innerHTML !== undefined) { | |||
There was a problem hiding this comment.
Two problems:
- Please do not use DOM API in React component, you should use
refinstead. - Clear the search words on each enter press will make it not possible to add multiple search keywords.
There was a problem hiding this comment.
感谢 review！为保持多关键词的搜索功能我打算撤销 pull request。
个人看法是：
- 目前网站采用的多段关键词搜索（如图1）不太符合直觉
- 多关键词的高级搜索通常是在同一行实现功能（如图2）
- 就网站目前的规模和求职者快速检索特定公司的需求而言，每次搜索时先清除上一次的记录可能更实用
 |
|---|
| Figure1: 多段关键词搜索 |
 |
|---|
| Figure2: 关键词搜索 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue of #28 (comment)