Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Latest minor/patch updates and react packages updates #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ValGeorgiev
Copy link
Contributor

Update all minor/patch updates of packages

  • Styled components did some minor changes in v5.2.0, that broke 2 of our snapshot tests. Update of snapshots is needed.

Preallocate global style placement to ensure cGS is consistently inserted at the top of the stylesheet; note that this is done in runtime order so, if you have multiple cGS that have overlapping styles, ensure they're defined in code in the sequence you would want them injected (see #3239)

Update react and react-dom packages

  • Enzyme is not working with react v17 yet. There is a non official adapter that is working for us, until official adapter is released

Update react-spring package

@andyrichardson
Copy link
Collaborator

Thanks for taking the time to do this @ValGeorgiev 🔥 Additional notes you've made help a massive amount 🚀

It looks like visual regression is working fine so I'm fairly comfortable with these changes. I'd say go ahead and merge it but if you have a short moment to try out basic user interactions (clicking around in cache/events view, triggering a request) in the full E2E (extension/standalone) - that should just ensure that event handlers are working as expected.

I'll pull your build artifact and do the same for the extension 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants