-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Also allow filtering by URL not just by request name #2808
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound Great
Hey @N-Ziermann Thanks for working on this. One issue with this approach is that the search results displayed do not indicate the context for why they were matched. This becomes problematic when there are many collections loaded with a variety of requests. |
Hey @helloanoop Thanks for your reply. I understand your concern. What do you think? |
There is another unmerges PR related to filtering #1230 , to allow folder name search, and it added a button to alternate between regular and by folder search, you culd add something similar |
Thanks for pointing that out @tlaloc911 What I could see as an option is a filter (kebab menu) to control which filters you want to have active combined with the indicator I described previously. |
Here is a little illustration of what I mean. It's of course not to scale and the colors aren't ideal, but it should get the point across. |
@tlaloc911 @N-Ziermann I am thinking of a collection level search that not just filters by url, but much more like search inside body, scripts, tests etc Let me know your thoughts. Here is a draft PR I have on this - #3823 Demo Screen.Recording.2025-01-17.at.3.28.38.AM.mov |
Description
Closes #2806.
It enables users to not only filter their request by name, but also by URL.
I also added unit tests for the function I edited and therefore needed to add a custom jest-config to the bruno-app package that uses the compilerOptions.paths property from the jsconfig.
This was necessary because jest doesn't automatically read that property from the jsconfig file and therefore couldn't understand the utils/common imports from the collections/index file used in search.js.
Contribution Checklist: