fix: space in any param name is blocking the loading of the request file in GUI #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile in GUI (usebruno#2878) Adjusted Bruno grammar so the `key` element does not disallow spaces (leading and trailing space is still trimmed).
pietrygamat
force-pushed
the
bugfix/allow-space-in-param-name-2878
branch
from
5c3d316 to
82e53ac
Compare
sanjai0py
approved these changes
Aug 23, 2024
lohxt1
approved these changes
Sep 2, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted Bruno grammar so the
keyelement does not disallow spaces (leading and trailing space is still trimmed).fixes #2878
fixes #2810
fixes #3942
More flexible solution, i.e. adding option to quote and escape certain special characters proposed as an alternative to this in #3045 and #3178
Contribution Checklist: