-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relocate empty clusters #2028
base: main
Are you sure you want to change the base?
Conversation
template <typename centroidsFPType> | ||
int TaskKMeansLloyd<algorithmFPType, cpu>::kmeansUpdatePoints(int jidx) | ||
{ | ||
int idx = (int)jidx; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why (int)
is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
if (clusterS0[i] > 0) | ||
{ | ||
const algorithmFPType coeff = 1.0 / clusterS0[i]; | ||
if (clusterS0[i] == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
should be on separate row. Use clang-format -i {files}
to apply code style:
conda install -c conda-forge clang-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
/intelci: run |
/intelci: run |
/intelci: run |
/intelci: restart |
Fix the problem due to the fact that empty clusters were not removed from previous clusters. Add new array to store in which cluster is the point.