Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): Update earn entrypoint #6233

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

finnian0826
Copy link
Contributor

Description

Consolidated all into EarnEntrypoint, added hasSuppliedPools prop to analytics event to know which version the user sees when they tap.

Test plan

Unit tests updated

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-11-14.at.15.25.31.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-11-14.at.15.26.09.mp4

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (e39b981) to head (58159ac).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6233      +/-   ##
==========================================
- Coverage   88.98%   88.97%   -0.01%     
==========================================
  Files         737      737              
  Lines       31449    31429      -20     
  Branches     5828     5526     -302     
==========================================
- Hits        27985    27965      -20     
- Misses       3266     3420     +154     
+ Partials      198       44     -154     
Files with missing lines Coverage Δ
src/analytics/Events.tsx 100.00% <ø> (ø)
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/dappsExplorer/TabDiscover.tsx 96.15% <100.00%> (-0.91%) ⬇️
src/earn/EarnEntrypoint.tsx 100.00% <100.00%> (ø)
src/images/Images.ts 100.00% <100.00%> (ø)
src/images/assets/earn-card-background.png 100.00% <ø> (ø)

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39b981...58159ac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant