Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct RediStack URL and match Vapor's minimum Swift version #211

Merged
merged 10 commits into from
Jun 20, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jun 20, 2023

Switches to the now-official GitHub URL for RediStack and raises the Swift minimum version to 5.6 to match Vapor.

(Swift version update requires minor version bump.)

@gwynne gwynne added the semver-minor Contains new APIs label Jun 20, 2023
@gwynne gwynne requested review from Joannis and 0xTim June 20, 2023 15:15
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the docs link that I can see

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b4fcda8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage        ?   55.58%           
=======================================
  Files           ?       11           
  Lines           ?      412           
  Branches        ?        0           
=======================================
  Hits            ?      229           
  Misses          ?      183           
  Partials        ?        0           

@gwynne gwynne requested a review from Joannis June 20, 2023 15:56
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the exports as part of this PR as well

@gwynne
Copy link
Member Author

gwynne commented Jun 20, 2023

@0xTim Done, along with the URL in the DocC bundle.

@gwynne gwynne requested a review from 0xTim June 20, 2023 16:14
@gwynne gwynne requested a review from 0xTim June 20, 2023 16:19
@gwynne gwynne merged commit 2a8d3e4 into main Jun 20, 2023
@gwynne gwynne deleted the gwynne-patch-2 branch June 20, 2023 16:32
@VaporBot
Copy link

These changes are now available in 5.0.0-alpha.2.2

@0xTim
Copy link
Member

0xTim commented Jun 20, 2023

@gwynne we need to either remove the old releases, actually release it (we could take the opportunity to remove exports etc) or fix the release bit, this should be a real release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants