Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (provider/google): add promptFeedback outputs #4265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggallon
Copy link
Contributor

@ggallon ggallon commented Jan 4, 2025

Hi,

I've added promptFeedback support from the response, fix: #4236

A new promptFeedback object has been added to the providerMetadata, with blockReason and safetyRatings.

Where is the best place to add this in the documentation?

@lgrammel lgrammel requested a review from shaper January 6, 2025 15:14
@lgrammel
Copy link
Collaborator

cc @shaper

@shaper
Copy link
Contributor

shaper commented Jan 16, 2025

Hi there, thank you for the contribution! I am looking at this PR and trying to reproduce a case to validate the intended behavior -- can you steer me toward example input? I recognize it could be difficult to share, if there are examples you can link to or if you prefer you can send me a note at [email protected].

I have found prompts that will cause Gemini to refuse to provide content, but I am not getting any promptFeedback data returned, and the finish reason is still STOP.

Did you modify the included example scripts to specify a different safety filter in the request or anything like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for the promptFeedback.blockReason in the Gemini streaming output
3 participants