-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider/amazon-bedrock): Add reasoning support #4980
base: main
Are you sure you want to change the base?
Conversation
Thank you! I will take a look at this soon. |
EDIT: Resolved in 31bef7c The issue was I wasn't adding the |
For what it's worth I took this patch and manually applied it locally and it works with sonnet 3.7 with both |
This is on my radar and I aim to get to it soon, thank you for your continued work here and contributions. We plan to work with you to get this landed as soon as we can. |
…ing vs redacted reasoning
…nd redacted reasoning
…ctly on doGenerate
This has literally been my experience with trying to write this, I swear: I feel like every time I think I have it done right, I do some testing, then experience some random edge case and find I did something wrong. @shaper, do you want to populate For example, right now, as of 468a750, if we call However, if we call And later in the response.messages: I genuinely have no idea how that's supposed to return, but something important to note. |
This adds reasoning support for Claude models in Amazon Bedrock, as noted in issue #4977.
I have tested these changes in my environment, and confirmed that we receive reasoning in both streaming and non-streaming configurations.
In streaming and non-streaming, both the signature and reasoning text are properly extracted. You may want to convert this to use
providerOptions
instead of relying onadditionalModelRequestFields
inBedrockChatSettings
, but I don't know the best practice for that.