Merge branch 'canary' into brody/add-vitest-config

eslint/browser.js

@@ -1,5 +1,5 @@
 module.exports = {
-  extends: require.resolve('./_base'),
+  extends: './_base',
   env: {
     browser: true,
   },

eslint/playwright-test.js

@@ -1,6 +1,7 @@
 module.exports = {
-  extends: [
-    'plugin:playwright/playwright-test',
-    require.resolve('./rules/playwright-test.js'),
-  ],
+  plugins: ['playwright'],
+  extends: [require.resolve('./rules/playwright-test.js')],
+  env: {
+    'shared-node-browser': true,
+  },
 };

eslint/rules/best-practice.js

@@ -162,12 +162,6 @@ module.exports = {
      * 🚫 Not fixable - https://eslint.org/docs/rules/no-return-assign
      */
     'no-return-assign': 'error',
-    /**
-     * Disallows unnecessary `return await`.
-     *
-     * 🚫 Not fixable - https://eslint.org/docs/rules/no-return-await
-     */
-    'no-return-await': 'error',
     /**
      * Disallow use of `javascript:` urls.
      *

eslint/rules/jest.js

@@ -12,11 +12,5 @@ module.exports = {
      * 🔧 Fixable - https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-lowercase-title.md
      */
     'jest/prefer-lowercase-title': 'warn',
-    /**
-     * Require test cases and hooks to be inside a `describe` block.
-     *
-     * 🚫 Not fixable - https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-top-level-describe.md
-     */
-    'jest/require-top-level-describe': 'error',
   },
 };

eslint/rules/playwright-test.js

@@ -1,9 +1,10 @@
-// Source: https://github.com/playwright-community/eslint-plugin-playwright/blob/main/src/index.ts
+// Source: https://github.com/playwright-community/eslint-plugin-playwright/blob/v1.5.1/src/index.ts#L101-L129
 const recommended = {
   'no-empty-pattern': 'off',
   'playwright/expect-expect': 'warn',
   'playwright/max-nested-describe': 'warn',
   'playwright/missing-playwright-await': 'error',
+  'playwright/no-conditional-expect': 'warn',
   'playwright/no-conditional-in-test': 'warn',
   'playwright/no-element-handle': 'warn',
   'playwright/no-eval': 'warn',
@@ -13,11 +14,17 @@ const recommended = {
   'playwright/no-networkidle': 'error',
   'playwright/no-page-pause': 'warn',
   'playwright/no-skipped-test': 'warn',
+  'playwright/no-standalone-expect': 'error',
+  'playwright/no-unsafe-references': 'error',
   'playwright/no-useless-await': 'warn',
   'playwright/no-useless-not': 'warn',
+  'playwright/no-wait-for-selector': 'warn',
   'playwright/no-wait-for-timeout': 'warn',
   'playwright/prefer-web-first-assertions': 'error',
+  'playwright/valid-describe-callback': 'error',
   'playwright/valid-expect': 'error',
+  'playwright/valid-expect-in-promise': 'error',
+  'playwright/valid-title': 'error',
 };
 
 module.exports = {
@@ -35,11 +42,5 @@ module.exports = {
      * 🔧 Fixable - https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/prefer-lowercase-title.md
      */
     'playwright/prefer-to-have-length': 'warn',
-    /**
-     * Require test cases and hooks to be inside a `test.describe` block.
-     *
-     * 🚫 Not fixable - https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/prefer-lowercase-title.md
-     */
-    'playwright/require-top-level-describe': 'error',
   },
 };

eslint/rules/possible-errors.js

@@ -1,11 +1,5 @@
 module.exports = {
   rules: {
-    /**
-     * Disallow await inside of loops.
-     *
-     * 🚫 Not fixable - https://eslint.org/docs/rules/no-await-in-loop
-     */
-    'no-await-in-loop': 'error',
     /**
      * Disallow the use of console.
      *

eslint/rules/react.js

@@ -81,12 +81,6 @@ module.exports = {
      * 🚫 Not fixable - https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md
      */
     'react/jsx-pascal-case': 'warn',
-    /**
-     * Require props to be sorted alphabetically.
-     *
-     * 🔧 Fixable - https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md
-     */
-    'react/jsx-sort-props': 'warn',
     /**
      * Disallow usage of Array index in keys.
      *

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vercel/style-guide",
-  "version": "5.3.0-canary.1",
+  "version": "5.3.0-canary.6",
   "description": "Vercel's engineering style guide",
   "homepage": "https://github.com/vercel/style-guide#readme",
   "bugs": {
@@ -49,7 +49,7 @@
     "eslint-plugin-import": "^2.28.1",
     "eslint-plugin-jest": "^27.2.3",
     "eslint-plugin-jsx-a11y": "^6.7.1",
-    "eslint-plugin-playwright": "^0.16.0",
+    "eslint-plugin-playwright": "^1.5.1",
     "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-testing-library": "^6.0.1",