Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(watch): warn if daemon is disabled #9407

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Nov 7, 2024

Description

Closes #9401

turbo watch cannot function without the daemon, we should warn users of this if they have tried to disable the daemon.

We could error if the daemon is disabled, but that would lead to awkward behavior if it is disabled in turbo.json. It's possible to want the daemon disabled for turbo run, but still want to use turbo watch.

Testing Instructions

Attempt running watch with an explicit request to disable the daemon:

[1 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev --no-daemon watch @turbo/types#build            
 WARNING  No locally installed `turbo` found. Using version: 2.2.4-canary.8.
turbo 2.2.4-canary.8

 WARNING  daemon is required for watch, ignoring request to disable daemon
• Packages in scope: @turbo-internal/top-issues-gh-action, @turbo/benchmark, @turbo/codemod, @turbo/eslint-config, @turbo/exe-stub, @turbo/gen, @turbo/telemetry, @turbo/test-utils, @turbo/tsconfig, @turbo/types, @turbo/utils, @turbo/workspaces, @turborepo-examples-tests/basic, @turborepo-examples-tests/design-system, @turborepo-examples-tests/kitchen-sink, @turborepo-examples-tests/non-monorepo, @turborepo-examples-tests/with-berry, @turborepo-examples-tests/with-changesets, @turborepo-examples-tests/with-npm, @turborepo-examples-tests/with-react-native-web, @turborepo-examples-tests/with-rollup, @turborepo-examples-tests/with-svelte, @turborepo-examples-tests/with-tailwind, @turborepo-examples-tests/with-vite, @turborepo-examples-tests/with-yarn, cargo-sweep-action, cli, create-turbo, eslint-config-turbo, eslint-plugin-turbo, prysk, turbo-ignore, turbo-vsc, turborepo-examples, turborepo-repository, turborepo-tests-helpers, turborepo-tests-integration
• Running @turbo/types#build in 37 packages
• Remote caching enabled
┌ @turbo/types#build > cache miss, executing 305999608c9295f1 
│ 
│ 
│ > @turbo/[email protected] build /Users/olszewski/code/vercel/turborepo/packages/turbo-types
│ > tsc && pnpm generate-schema
│ 
│ 
│ > @turbo/[email protected] generate-schema /Users/olszewski/code/vercel/turborepo/packages/turbo-types
│ > tsx scripts/generate-schema.ts
└────>
  × watch interrupted due to signal

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 9:52pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 9:52pm

@chris-olszewski chris-olszewski merged commit 931e636 into main Nov 13, 2024
40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_warn_on_no_daemon_watch branch November 13, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does --no-daemon really work?
2 participants