RSDK-9808 Persist OTAA data across restarts #22
Conversation
There was a problem hiding this comment.
LGTM, random nit thoughts I'm having
-
wondering if all of the read/write/create stuff for the deviceInfo file should be in its own devicefile.go file, but the way things are organized now is fine.
-
it was alittle hard to parse the gateway.go DoCommand code, wondering if there could be another helper function in there. Gut says no because of how the
deviceInfo != nilcheck is used
gateway/gateway.go
Outdated
| @@ -389,6 +410,22 @@ func (g *gateway) DoCommand(ctx context.Context, cmd map[string]interface{}) (ma | |||
| return nil, err | |||
| } | |||
| g.devices[node.NodeName] = mergedNode | |||
|
|
|||
| // Check if the device is in the persistent data file, if it is add the OTAA info. | |||
| deviceInfo, err := g.searchForDeviceInFile(mergedNode.DevEui) | |||
There was a problem hiding this comment.
spoke offline about this, technically the DoCommand and handlePacket can both interact with the file at the same time.
Possibly want a mutex just for reading the file? unsure of the right way to handle, or if its such a small chance of happening maybe we don't worry about it
There was a problem hiding this comment.
Nice catch, John - let's get some data. I can imagine Chris running this document with a user that has a file with many sensors; Olivia, can you fold that into your manual tests?
There was a problem hiding this comment.
Added 10 sensors to my config and sometimes got a nil pointer in docommand that locking the mutex fixed. I didn't see any issues with the handlepacket routine writing to the file but it might be because the join requests don't happen very often.
Currently, if the module is restarted the dev addr and keys will be lost and the device needs to resend a join request. This PR writes the OTAA info of each device to a file during the join procedure. When a previously known device is registered to the gateway through the docommand, the device's info is pulled from the file and added to the device object. Now the device does not need to be manually reset if the module gets restarted.
Testing: Added unit tests for each function, tested manually using tilt sensor.
To do:
[ ] more manual testing