Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use headless opencv #28

Closed
wants to merge 6 commits into from
Closed

use headless opencv #28

wants to merge 6 commits into from

Conversation

abe-winter
Copy link

Warning ⚠️

I didn't test this (I don't know how)

What changed

  • use opencv-headless instead of the full version
  • misc cleanup to simplify build

Why

Currently, we install the full version of the opencv python library, which on ubuntu has apt-get dependencies that are not always present (causing the pyinstaller binary to fail to start). Headless seems to fix that. Headless also likely produces smaller binaries (but I didn't check).

⚠️ warning, there may be missing features at runtime from switching from full opencv to headless.

Alternatives

Create a run.sh wrapper which detects the platform and does apt installs where necessary

@abe-winter abe-winter marked this pull request as draft August 12, 2024 18:27
@penguinland
Copy link
Contributor

Dang, this is, like, 6 months old and nobody has looked at it. Abe, do you still want someone to look at this? If so, fix the merge conflicts and assign me as a reviewer.

@abe-winter
Copy link
Author

your call if this is useful -- if yes I will fix up for merge, if not I'll close

the headless version of opencv has fewer system library dependencies and is easier to install

@penguinland
Copy link
Contributor

I talked with Khari: we both think this is useful! Clean it up, and I'll make sure it works on both an Orin Nano and a Raspberry Pi, and we'll go from there.

@abe-winter
Copy link
Author

fixed merge conflict but the dist/main produced by pyinstaller seems nonfunctional -- closing this as low pri. feel free to reopen and tinker if you want

@abe-winter abe-winter closed this Feb 12, 2025
@abe-winter abe-winter deleted the headless branch February 12, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants