-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-9931] Let the config have an optional maximum bounding box #31
Merged
penguinland
merged 12 commits into
viam-modules:main
from
penguinland:maximum_motion_amount
Feb 13, 2025
Merged
[RSDK-9931] Let the config have an optional maximum bounding box #31
penguinland
merged 12 commits into
viam-modules:main
from
penguinland:maximum_motion_amount
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...this time with not just the old tests passing, but new tests that also pass! |
penguinland
commented
Feb 12, 2025
… object at 0xffff99489f30>'
693cf20
to
ad05127
Compare
kharijarrett
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is that if the camera provides a corrupted frame and everything suddenly goes gray for a moment, that shouldn't count as motion. This also means that if someone bumps the camera and the entire scene shifts to the left, that also shouldn't count as motion.
Tried on an Orin Nano: seems to work! edit: if I don't mention it in the config, the behavior seems unchanged, and if I do mention it, large bounding boxes do not appear, while small ones still do. I was unable to get a corrupted image, so can't ensure that those are no longer considered noise.
I've also made some other cleanup changes:
Exception
s, because the only way to catch them is to catch all exceptions. Instead, raise something specific (in these cases, I went withValueError
, but could be convinced of other types, too).My hope is that reviewing commit-by-commit is easy, and makes it clear why each change occurred.