Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prettier-config)!: split configs and use direct dependencies #49

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mcous
Copy link
Member

@mcous mcous commented Nov 27, 2024

Overview

This stack of PRs updates our common JS configs over to their 1.0.0 versions. The main difference between the versions so far and v1 is that (thanks to the ESLint v9 update) the various plugins and configs that we stitch together will be pulled in automatically as dependencies - simplifying setup by removing most required peer dependencies.

  1. ci: release with pnpm publish instead of action #48
  2. 🌿 feat(prettier-config)!: split configs and use direct dependencies #49
  3. feat(eslint-config)!: split config packages #50
  4. TODO: Update ESLint packages to use ESLint v9 and flat configs

Change log

This PR splits the prettier config up into two separately installable packages, including all required dependencies other than prettier itself.

  • @viamrobotics/prettier-config
  • @viamrobotics/prettier-config-svelte

Before:

pnpm add --save-dev prettier @viamrobotics/prettier-config prettier-plugin-svelte prettier-plugin-tailwindcss

After:

pnpm add --save-dev prettier @viamrobotics/prettier-config-svelte

Review requests

Check out the new setup instructions in the relevant README's. I've smoke tested these configs in app, and after taking care of a few minor issues, they seem to be behaving

@mcous mcous force-pushed the lint/prettier-config-mjs branch from 5d046f1 to 8208c54 Compare November 27, 2024 22:14
@mcous mcous changed the title feat(prettier-config): split configs and use direct dependencies feat(prettier-config)!: split configs and use direct dependencies Nov 27, 2024
@mcous mcous force-pushed the lint/prettier-config-mjs branch from 8208c54 to 78d51c3 Compare December 2, 2024 15:04
@mcous mcous force-pushed the ci/switch-to-pnpm-publish branch from edffb31 to 5a83a43 Compare December 2, 2024 15:17
@mcous mcous force-pushed the lint/prettier-config-mjs branch from 78d51c3 to 7d72ede Compare December 2, 2024 15:17
@mcous mcous marked this pull request as ready for review December 2, 2024 15:20
@mcous mcous force-pushed the lint/prettier-config-mjs branch from 7d72ede to db3dcee Compare December 2, 2024 16:16
@mcous mcous force-pushed the lint/prettier-config-mjs branch 2 times, most recently from 03da2c3 to 190557c Compare December 2, 2024 21:32
Base automatically changed from ci/switch-to-pnpm-publish to main December 2, 2024 22:04
@mcous mcous force-pushed the lint/prettier-config-mjs branch from 190557c to d16e201 Compare December 2, 2024 22:06
"version": "0.3.6",
"description": "Common Prettier configuration for Viam projects.",
"type": "commonjs",
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@mcous mcous merged commit e33aec8 into main Dec 2, 2024
3 checks passed
@mcous mcous deleted the lint/prettier-config-mjs branch December 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants