-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prettier-config)!: split configs and use direct dependencies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2024
5d046f1
to
8208c54
Compare
8208c54
to
78d51c3
Compare
edffb31
to
5a83a43
Compare
78d51c3
to
7d72ede
Compare
ethanlookpotts
approved these changes
Dec 2, 2024
ehhong
approved these changes
Dec 2, 2024
7d72ede
to
db3dcee
Compare
zaporter-work
approved these changes
Dec 2, 2024
03da2c3
to
190557c
Compare
190557c
to
d16e201
Compare
katiepeters
approved these changes
Dec 2, 2024
"version": "0.3.6", | ||
"description": "Common Prettier configuration for Viam projects.", | ||
"type": "commonjs", | ||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This stack of PRs updates our common JS configs over to their
1.0.0
versions. The main difference between the versions so far andv1
is that (thanks to the ESLint v9 update) the various plugins and configs that we stitch together will be pulled in automatically asdependencies
- simplifying setup by removing most required peer dependencies.pnpm publish
instead of action #48Change log
This PR splits the prettier config up into two separately installable packages, including all required dependencies other than
prettier
itself.@viamrobotics/prettier-config
@viamrobotics/prettier-config-svelte
Before:
After:
Review requests
Check out the new setup instructions in the relevant README's. I've smoke tested these configs in app, and after taking care of a few minor issues, they seem to be behaving