RSDK-9623: Add Discover Service and GetModelsFromModules to Python #827
Conversation
martha-johnston
force-pushed
the
rsdk-9623
branch
from
76b697e to
574ade1
Compare
martha-johnston
force-pushed
the
rsdk-9623
branch
from
0dac527 to
e1832aa
Compare
martha-johnston
changed the title
| @@ -16,7 +16,7 @@ buf: clean | |||
| rm -rf src/viam/gen | |||
| chmod +x plugin/main.py | |||
| uv pip install protoletariat | |||
| uv pip install protobuf==5.29.1 | |||
| uv pip install protobuf==5.29.3 | |||
There was a problem hiding this comment.
want to call attention to this upgrade and make sure there's no issue with it
There was a problem hiding this comment.
I think it's probably fine but I haven't looked into it deeply. Curious though why this upgrade is important?
There was a problem hiding this comment.
with 5.29.1, when I run make buf locally I get the following error
Detected incompatible Protobuf Gencode/Runtime versions when loading common/v1/common.proto: gencode 5.29.3 runtime 5.29.1. Runtime version cannot be older than the linked gencode version. See Protobuf version guarantees at https://protobuf.dev/support/cross-version-runtime-guarantee.
and I don't remember what the exact error was on GitHub but the checks did not pass either, I assume because the correct protos weren't present since I couldn't build them? so I upgraded protobuf and was able to run make buf successfully, and then the GitHub checks passed
| @@ -16,7 +16,7 @@ buf: clean | |||
| rm -rf src/viam/gen | |||
| chmod +x plugin/main.py | |||
| uv pip install protoletariat | |||
| uv pip install protobuf==5.29.1 | |||
| uv pip install protobuf==5.29.3 | |||
There was a problem hiding this comment.
I think it's probably fine but I haven't looked into it deeply. Curious though why this upgrade is important?
|
yes I will! but I discovered this morning that |
|
okay issue resolved, I thought it was an sdk issue but it was unimplemented in rdk, works now that the implementation has been merged. and merged main so it should be updated with latest @njooma |
add
discoverResourcesandgetModelsFromModulesto python sdk, deprecation warnings are already added in #818