Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web.JSON: fix char encodes #743

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Web.JSON: fix char encodes #743

merged 2 commits into from
Jun 28, 2020

Conversation

Milly
Copy link
Contributor

@Milly Milly commented May 21, 2020

This is part of #695, only bug fixes.

  • Encode all control chars.
    • Prev: only \r, \n and \t are converted.
    • Fixed: all of \x01 to \x1f are converted.
  • Decode UTF-16 surrogate pairs.
    • Prev: can not decoded.
    • Fixed: can decoded.

@Milly Milly mentioned this pull request May 21, 2020
Open
@Milly Milly changed the title Web.json: fix char encodes Web.JSON: fix char encodes May 21, 2020
@Milly
Copy link
Contributor Author

Milly commented Jun 8, 2020

It is unrelated failures:

  • Deprecated.Text.Sexp parse
  • Async.Later .call() calls tasks in FIFO manner (nest)

@Milly Milly force-pushed the Web.JSON-fix-char-encodes branch from 5c35971 to c308a9c Compare June 10, 2020 05:06
lambdalisue
lambdalisue approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujihisa ujihisa merged commit ff55b7a into vim-jp:master Jun 28, 2020
@Milly Milly deleted the Web.JSON-fix-char-encodes branch July 28, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdalisue lambdalisue lambdalisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Milly @lambdalisue @ujihisa