WIP: program added/removed events #48

travisghansen · 2020-07-04T16:50:15Z

This allows registering callbacks for 2 different scenarios:

added/removed callback for programs directly on the controller
removed callback fired directly on the program

Example usage:

import time
from pyopensprinkler import Controller as OpenSprinklerController

def premoved(program):
    print("program object callback")
    print(program.index)

def pobserver(controller, action, index):
    print(f"station {index} {action}")
    if action == "added":
        print(controller.programs[index])
        controller.programs[index].add_on_removed_observer(premoved)

controller = OpenSprinklerController(...)
controller.add_program_observer(pobserver)

controller.refresh()
# go change program name
# add or remove programs
# etc
time.sleep(10)

# should trigger callbacks
controller.refresh()

exit(0)

The callback directly on the program will make it easier to bind an entity to the removal process and deregister the entity with hass in a more self-contained manner.

vinteo · 2020-07-04T22:22:37Z

For the sake of completeness should we have a de-register callback too?

Should there be a different event for "rename"?

Can you open a proof on concept on the HA side too?

vinteo · 2020-07-04T22:23:58Z

pyopensprinkler/program.py

@@ -67,6 +68,9 @@ def _get_data_flag_bits(self):
    def _set_data_flag_bit(self, index, value):
        print("foo")

+    def add_on_removed_observer(self, observer):


technically it is both add and remove so the name is a bit off

This is actually just remove. Chicken/egg for added.

Meaning if you’re adding a callback for added on a program...the program is already added (in the context of a program instance).

yea but you have both "added" and "removed" "events". Maybe just add_observer?

The event on the program directly is only removed..

travisghansen · 2020-07-04T22:55:52Z

The controller callback serves both added and removed. For simplicity I think it would be difficult try to manage a rename/modify event and would probably stick with a modify is a remove and subsequent add.