Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for size of token replacements when sizing the bar #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FremyCompany
Copy link

If we are not doing this, then the bar can overflow to the next line, then it starts drawing itself over and over again, because the start of the line is not the real start of the line but the start of the wrapped line, and that is really annoying...

Since we want the bar size to remain stable, the maximum size for a token is remembered.

If we are not doing this, then the bar can overflow to the next line, then it starts drawing itself over and over again, because the start of the line is not the real start of the line but the start of the wrapped line, and that is really annoying...

Since we want the bar size to remain stable, the maximum size for a token is remembered.
@FremyCompany
Copy link
Author

This was prompted by the line wrapping issue happening in tensorflow.js and driving me nuts.

cc @bileschi @caisq (if this isn't merged, the fix is to make the name of the token dependent of its expected size, which sucks but sucks less than outputting a new progressbar for every batch)

And ignore replacements that aren't appearing in the template
@caisq
Copy link

caisq commented Mar 29, 2019

@FremyCompany Can you file an issue at TensorFlow.js' Issues page with details on the model you are using?

@FremyCompany
Copy link
Author

@caisq Sure. This would happen for any model that has a few outputs/metrics.

@caisq
Copy link

caisq commented Mar 29, 2019

@FremyCompany Got it. I think I know what the problem is, but will appreciate you filing an issue formally regardless. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants