feat!: proxy bypass with WebSocket #18070
Merged
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p2-edge-case
|
|
patak-dev
approved these changes
Oct 30, 2024
patak-dev
changed the title
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Oct 30, 2024
bluwy
pushed a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#13218 made Vite's internal WebSocket connection to be able to be proxyed to other servers. But that made it impossible to proxy WebSocket connections while not proxying the internal WebSocket connection (See the table below).
//aaa//aaaThis PR makes
proxyOptions.bypassto be called for WebSocket connections and make that possible.An alternative is to change the WebSocket protocol to
vite-hmr-${randomid}instead ofvite-hmrand proxy all WS connections except connections withvite-hmr-${randomid}. Proxying other Vite server's WS connection is possible because other Vite server would have a differentrandomid.fixes #17973