fix(css): fix missing source file warning with sass modern api custom importer #18113
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
https://sass-lang.com/documentation/js-api/interfaces/importerresult/#sourceMapUrl vite/packages/vite/src/node/plugins/css.ts Line 2303 in 993d45b Could you try to see if it works? |
sapphi-red
added
feat: css
p3-minor-bug
…i custom importer" This reverts commit 4536314.
Oops, I totally missed that somehow. This totally works, thanks! |
bluwy
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sourcemap for ... points to missing source filesfor@importwith sass modern api #18111I addedEDIT:data:to "missing source" false positive list since Sass modern API usesdata:...when the code is loaded from custom importer. This would meancss.devSourcemapworks only for the initial import of sass files, which is pretty bad, but I couldn't find any solution for this.sourceMapUrlworks #18113 (comment)