-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Support excluding lagging tablets and use this in vstream manager #17835
Conversation
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Matt Lord <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank you for the super quick fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17835 +/- ##
==========================================
- Coverage 67.45% 67.43% -0.02%
==========================================
Files 1592 1592
Lines 258167 258173 +6
==========================================
- Hits 174143 174109 -34
- Misses 84024 84064 +40 ☔ View full report in Codecov by Sentry. |
…am manager (vitessio#17835) Signed-off-by: Matt Lord <[email protected]>
…am manager (vitessio#17835) Signed-off-by: Matt Lord <[email protected]>
…am manager (vitessio#17835) Signed-off-by: Matt Lord <[email protected]>
Description
This PR adds support in the TabletPicker for excluding tablets that have MySQL replication lag higher than a given maximum value. It then uses this new support in the VTGate vstream manager to exclude candidates that would immediately fail when we start the health check stream from the selected tablet.
Related Issue(s)
Checklist