Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting attention kernel file #10091

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Splitting attention kernel file #10091

merged 1 commit into from
Nov 12, 2024
+399 −328

Conversation

maleksan85
Copy link
Contributor

@maleksan85 maleksan85 commented Nov 6, 2024 •
edited
Loading

Split paged attention kernel into two files for v1 and v2 to speed up compilation when template instantiation explodes.

side effect: support Navi32

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 6, 2024
@maleksan85 maleksan85 marked this pull request as ready for review November 6, 2024 20:17
@maleksan85 maleksan85 force-pushed the splitting_attention_kernel_file branch from 8a08b8f to ef85d7d Compare November 6, 2024 20:18
duplicate attention kernel file
429b7d9 
Signed-off-by: maleksan85 <[email protected]>

finishging split

clean up

Signed-off-by: maleksan85 <[email protected]>
@maleksan85 maleksan85 force-pushed the splitting_attention_kernel_file branch from ef85d7d to 429b7d9 Compare November 6, 2024 20:25
tlrmchlsmth
tlrmchlsmth reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Do you have measurements for compile time for these files before and with this change?

@maleksan85
Copy link
Contributor Author

maleksan85 commented Nov 6, 2024 •
edited
Loading

Seems reasonable. Do you have measurements for compile time for these files before and with this change?

I didn't measure but on my non server machine I stopped to see timeouts during build. Also there will be change that increases compile time constants number. Different for AMD MI and AMD Navi thus increasing number of template instantiations and compile time.

@maleksan85
Copy link
Contributor Author

@tlrmchlsmth are you OK with the change or there are some concerns? If OK, please approve.

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 9, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 9, 2024 06:18
@DarkLight1337
Copy link
Member

@mergify-io rebase

@russellb
Copy link
Collaborator

russellb commented Nov 9, 2024

@mergify-io rebase

oops, sorry, should be @Mergifyio rebase

@DarkLight1337
Copy link
Member

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented Nov 9, 2024

rebase

❌ Unable to rebase: user DarkLight1337 is unknown.

Please make sure DarkLight1337 has logged in Mergify dashboard.

@DarkLight1337
Copy link
Member

https://github.com/Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented Nov 9, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@ROCm needs to authorize modification on its head branch.

@youkaichao youkaichao merged commit 812c981 into vllm-project:main Nov 12, 2024
77 checks passed
@maleksan85 maleksan85 deleted the splitting_attention_kernel_file branch November 12, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maleksan85 @DarkLight1337 @russellb @tlrmchlsmth @youkaichao