-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on serving with Llama Stack #10183
Conversation
Signed-off-by: Yuan Tang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to mention the inline integration, as well?
https://github.com/meta-llama/llama-stack/tree/main/llama_stack/providers/inline/inference/vllm
Definitely! I'll update this in a bit. Let me see if I can find the relevant guide. I wasn't sure if that's available yet. |
Signed-off-by: Yuan Tang <[email protected]>
@russellb I couldn't find a guide yet but I have added a reference to the inline implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested an addition of sample config
Thanks! Looking good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than adding Signed-off-by
to the commits so DCO will pass, this lgtm now. Thanks!
Feel free to add my Signed-off-by
to the co-authored commit with my addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think you need one more change. Right now you'll get an error that this page is not listed anywhere:
checking consistency... /Users/rbryant/src/vllm/docs/source/serving/serving_with_llamastack.rst: WARNING: document isn't included in any toctree
I would add this to docs/source/serving/integrations.rst
Co-authored-by: Russell Bryant <[email protected]> Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
7d2070e
to
b138d76
Compare
Should be fixed now! |
Build failures seem unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the integration!
See guide in https://github.com/meta-llama/llama-stack/blob/main/docs/source/getting_started/distributions/self_hosted_distro/remote_vllm.md