Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on serving with Llama Stack #10183

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

Copy link

github-actions bot commented Nov 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 9, 2024
Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrytangyuan
Copy link
Contributor Author

Definitely! I'll update this in a bit. Let me see if I can find the relevant guide. I wasn't sure if that's available yet.

@terrytangyuan
Copy link
Contributor Author

@russellb I couldn't find a guide yet but I have added a reference to the inline implementation.

Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested an addition of sample config

docs/source/serving/serving_with_llamastack.rst Outdated Show resolved Hide resolved
@terrytangyuan
Copy link
Contributor Author

Thanks! Looking good.

Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than adding Signed-off-by to the commits so DCO will pass, this lgtm now. Thanks!

Feel free to add my Signed-off-by to the co-authored commit with my addition.

Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think you need one more change. Right now you'll get an error that this page is not listed anywhere:

checking consistency... /Users/rbryant/src/vllm/docs/source/serving/serving_with_llamastack.rst: WARNING: document isn't included in any toctree

I would add this to docs/source/serving/integrations.rst

terrytangyuan and others added 2 commits November 11, 2024 11:35
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan
Copy link
Contributor Author

Should be fixed now!

@terrytangyuan
Copy link
Contributor Author

Build failures seem unrelated.

Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the integration!

@youkaichao youkaichao merged commit 4800339 into vllm-project:main Nov 11, 2024
19 of 21 checks passed
@terrytangyuan terrytangyuan deleted the llama-stack branch November 12, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants