Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue8294: inherit k8s default volumeSnapshotClass #8721

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hu-keyu
Copy link

@hu-keyu hu-keyu commented Feb 25, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Make compatible changes based on the GetVolumeSnapshotClassForStorageClass method,not break existing behaviour.

Does your change fix a particular issue?

Fixes #8294

Please indicate you've done the following:

@hu-keyu
Copy link
Author

hu-keyu commented Feb 25, 2025

review comments on PR 8719 has resovled,submit a new PR.

please reivew this PR @anshulahuja98

@hu-keyu
Copy link
Author

hu-keyu commented Feb 25, 2025

please review PR #8721 , thanks

kaovilai
kaovilai previously approved these changes Feb 25, 2025
@kaovilai
Copy link
Member

kaovilai commented Feb 25, 2025

@hu-keyu this might not merge until 1.16 release is cut FYI.
Also please fix your DCO
.

@anshulahuja98
Copy link
Collaborator

anshulahuja98 commented Feb 26, 2025

@hu-keyu can you add this in the website docs also ?
On the page where we talk about user to put the label, we should tell them that they could also apply the annotation on VSClass.

@hu-keyu
Copy link
Author

hu-keyu commented Feb 26, 2025

Which file should I add it to? @anshulahuja98

@anshulahuja98
Copy link
Collaborator

PR LGTM, CI is running currently.
We will merge this once 1.16 branch is cut. Holding onto PR Approval till then.
Thank you for your contribution @hu-keyu

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.53%. Comparing base (0f81772) to head (1d08b46).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/csi/volume_snapshot.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8721      +/-   ##
==========================================
+ Coverage   59.48%   59.53%   +0.04%     
==========================================
  Files         371      371              
  Lines       40191    40203      +12     
==========================================
+ Hits        23909    23936      +27     
+ Misses      14789    14769      -20     
- Partials     1493     1498       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants