-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiet option fix #444
base: dev
Are you sure you want to change the base?
Quiet option fix #444
Conversation
6cc66b0
to
f3000c0
Compare
We can also fix this by doing something like:
But this will be a costly operation. Let's fail early and quick. Imagine downloading giga byte size package on a slow network and seeing this error post download. |
The question is before downloading packages though. Which makes sense because you want to say be able to say "no" before downloading gigabytes on your modem link. |
Ahh, I missed it. Shall we switch to this solution? Simple and easy to maintain. |
Yes, agreed. |
I think this looks good. But as discussed, this will be merged some time in the future for Photon > 5.0 (I created a label for that purpose). |
No problem. Thanks. |
Signed-off-by: Shreenidhi Shedi <[email protected]>
Signed-off-by: Shreenidhi Shedi <[email protected]>
No description provided.