Add defined type and facts to generate and export/collect keys across nodes #8
Conversation
edestecd
changed the title
… nodes This creates a fact for each found public ssh key for all users with uid above 500. The defined type then creates an ssh_key, uses the fact to scoop up the detail and then exports/collects it on another node.
|
Hmm, lots of build errors. I guess, some features require the future parser or Puppet 4. |
That would be foremost the iterations. The checks on newer puppet versions seem to fail only on the undeclared $bits_opt variable. I would greatly appreciate this feature, it's especially useful for deploying generated keys with forced commands, for example for backup commands. |
|
We probably need to update this module and drop puppet 3 support in a major version release. |
|
@edestecd Puppet 3 support will be dropped as part of the Voxpupuli cutover. |
|
OK cool. I'll look into updating this with our latest code and adding some tests. |
|
Hi @edestecd, thanks for this PR. Are you able to rebase? |
|
I've got a rebased version at https://github.com/runejuhl/puppet-ssh_keygen/tree/pr/8 if it has any interest. |
|
@runejuhl are you interested in creating a PR with the changes? |
|
@bastelfreak sure! I had forgotten about this one. I'll submit a PR sometime soon |
|
New PR available at #49 |
|
Dear @edestecd, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @edestecd, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @edestecd, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @edestecd, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
This creates a fact for each found public ssh key for all users with uid above 500.
The defined type then creates an ssh_key, uses the fact to scoop up the detail and then
exports/collects it on another node.