Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load default acknow list when init AcknowListSwiftUIView #126

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tisfeng
Copy link

@tisfeng tisfeng commented Nov 6, 2024

Refer #124

    public init(acknowList: AcknowList? = AcknowParser.defaultAcknowList()) {
        self.init(
            acknowledgements: acknowList?.acknowledgements ?? [],
            headerText: acknowList?.headerText,
            footerText: acknowList?.footerText)
    }

return pods + packages
var acknowList = pods + packages
// If have both pods and packages libraries, remove the footer text from the pods.
acknowList.footerText = nil
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removed pods footer text, because here have both sources.

image

@tisfeng
Copy link
Author

tisfeng commented Nov 7, 2024

I didn't change a lot of the code, there were some code changes that were caused by IDE auto-formatting, so feel free to change that back if it matters to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant