Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(compiler-vapor): template abbreviation of end tag #186

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CathLee
Copy link

@CathLee CathLee commented Apr 21, 2024

related:#166
I've made some optimizations to ensure 'abbreviation' equals 'expected' through the IR, and added the 'isShouldSelfClosing' tag to the Node type. I'm not entirely sure it's correct, but it seems to work🧐

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit f37756d
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/662f4c1263b6ed00084bd0d7
😎 Deploy Preview https://deploy-preview-186--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit f37756d
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/662f4c12745bcd00082a5880
😎 Deploy Preview https://deploy-preview-186--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked unit test, and it failed

Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.5 kB (+1.39 kB) 28.4 kB (+219 B) 25 kB (+231 B)
compiler-vapor.global.prod.js 53.7 kB (+1.49 kB) 18.1 kB (+228 B) 16.4 kB (+136 B)
runtime-dom.global.prod.js 94.7 kB 35.6 kB 32.2 kB
runtime-vapor.global.prod.js 43.1 kB 16 kB 14.7 kB
vue-vapor.global.prod.js 94.3 kB (+1.49 kB) 32.7 kB (+241 B) 29.5 kB (+193 B)
vue.global.prod.js 153 kB (+1.39 kB) 55.2 kB (+240 B) 49.3 kB (+169 B)

Usages

Name Size Gzip Brotli
createApp 54.9 kB 21.1 kB 19.2 kB
createSSRApp 58.2 kB 22.4 kB 20.4 kB
defineCustomElement 57.2 kB 21.8 kB 19.9 kB
vapor 43.4 kB 16.1 kB 14.7 kB
overall 68.6 kB 26.1 kB 23.6 kB

@sxzz sxzz changed the title perf(compiler-core):template abbreviation of end tag perf(compiler-vapor): template abbreviation of end tag Apr 22, 2024
@sxzz sxzz marked this pull request as draft April 23, 2024 17:08
@sxzz
Copy link
Member

sxzz commented Apr 28, 2024

Are you still working on this PR?

@CathLee
Copy link
Author

CathLee commented Apr 29, 2024

Are you still working on this PR?
yes, already done a little work , but not sure about whether is right or not, I will give another pr right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants