fix(compiler-core): When the user uses the key inappropriately in the template, a compilation error should be thrown. #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ind has no expression, an error should be thrown
Size ReportBundles
Usages
|
|
What about v-if? |
The key of v-if is set internally. If the user manually sets the key, it will not take effect.
|
|
Thanks for the explanation, perhaps we'd add a warning or improve the document |
…template, a compilation error should be thrown
linzhe141
changed the title
linzhe141
changed the title
edison1105
reviewed
Aug 28, 2024
| if ((__DEV__ || !__BROWSER__) && isTemplate) { | ||
| const keyProp = findProp(node, `key`, false, true) | ||
| if (keyProp) { | ||
| context.onError( |
There was a problem hiding this comment.
It shouldn't be thrown an error. I think I should use the user-passed key here, just like normal elements.
see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11322