Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test cases #12678

Open
wants to merge 3 commits into
base: vapor
Choose a base branch
from
Open

test: update test cases #12678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a1db28
test: update test cases
edison1105 Jan 10, 2025
2d35746
test: update test cases
edison1105 Jan 10, 2025
d948c5b
test: update tests
edison1105 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 35 additions & 47 deletions packages/runtime-vapor/__tests__/apiLifecycle.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
} from '@vue/runtime-dom'
import {
createComponent,
// createIf,
createIf,
createTextNode,
renderEffect,
setText,
Expand Down Expand Up @@ -130,14 +130,13 @@ describe('api: lifecycle hooks', () => {
expect(fn).toHaveBeenCalledTimes(1)
})

it.todo('onBeforeUnmount', async () => {
it('onBeforeUnmount', async () => {
const toggle = ref(true)
const fn = vi.fn(() => {
expect(host.innerHTML).toBe('<div></div>')
expect(host.innerHTML).toBe('<div></div><!--if-->')
})
const { render, host } = define({
setup() {
// @ts-expect-error
const n0 = createIf(
() => toggle.value,
() => createComponent(Child),
Expand All @@ -160,18 +159,17 @@ describe('api: lifecycle hooks', () => {

toggle.value = false
await nextTick()
// expect(fn).toHaveBeenCalledTimes(1) // FIXME: not called
expect(fn).toHaveBeenCalledTimes(1)
expect(host.innerHTML).toBe('<!--if-->')
})

it.todo('onUnmounted', async () => {
it('onUnmounted', async () => {
const toggle = ref(true)
const fn = vi.fn(() => {
expect(host.innerHTML).toBe('<div></div>')
expect(host.innerHTML).toBe('<!--if-->')
})
const { render, host } = define({
setup() {
// @ts-expect-error
const n0 = createIf(
() => toggle.value,
() => createComponent(Child),
Expand All @@ -194,18 +192,17 @@ describe('api: lifecycle hooks', () => {

toggle.value = false
await nextTick()
// expect(fn).toHaveBeenCalledTimes(1) // FIXME: not called
expect(fn).toHaveBeenCalledTimes(1)
expect(host.innerHTML).toBe('<!--if-->')
})

it.todo('onBeforeUnmount in onMounted', async () => {
it('onBeforeUnmount in onMounted', async () => {
const toggle = ref(true)
const fn = vi.fn(() => {
expect(host.innerHTML).toBe('<div></div>')
expect(host.innerHTML).toBe('<div></div><!--if-->')
})
const { render, host } = define({
setup() {
// @ts-expect-error
const n0 = createIf(
() => toggle.value,
() => createComponent(Child),
Expand All @@ -230,25 +227,24 @@ describe('api: lifecycle hooks', () => {

toggle.value = false
await nextTick()
// expect(fn).toHaveBeenCalledTimes(1) // FIXME: not called
expect(fn).toHaveBeenCalledTimes(1)
expect(host.innerHTML).toBe('<!--if-->')
})

it.todo('lifecycle call order', async () => {
it('lifecycle call order', async () => {
const count = ref(0)
const toggle = ref(true)
const calls: string[] = []

const { render } = define({
setup() {
onBeforeMount(() => calls.push('onBeforeMount'))
onMounted(() => calls.push('onMounted'))
onBeforeUpdate(() => calls.push('onBeforeUpdate'))
onUpdated(() => calls.push('onUpdated'))
onBeforeUnmount(() => calls.push('onBeforeUnmount'))
onUnmounted(() => calls.push('onUnmounted'))

// @ts-expect-error
onBeforeMount(() => calls.push('root onBeforeMount'))
onMounted(() => calls.push('root onMounted'))
onBeforeUpdate(() => calls.push('root onBeforeUpdate'))
onUpdated(() => calls.push('root onUpdated'))
onBeforeUnmount(() => calls.push('root onBeforeUnmount'))
onUnmounted(() => calls.push('root onUnmounted'))

const n0 = createIf(
() => toggle.value,
() => createComponent(Mid, { count: () => count.value }),
Expand Down Expand Up @@ -290,44 +286,37 @@ describe('api: lifecycle hooks', () => {
}

// mount
render()
const ctx = render()
expect(calls).toEqual([
'onBeforeMount',
'root onBeforeMount',
'mid onBeforeMount',
'child onBeforeMount',
'child onMounted',
'mid onMounted',
'onMounted',
'root onMounted',
])

calls.length = 0

// update
count.value++
await nextTick()
// FIXME: not called
// expect(calls).toEqual([
// 'root onBeforeUpdate',
// 'mid onBeforeUpdate',
// 'child onBeforeUpdate',
// 'child onUpdated',
// 'mid onUpdated',
// 'root onUpdated',
// ])
// only child updated
expect(calls).toEqual(['child onBeforeUpdate', 'child onUpdated'])

calls.length = 0

// unmount
toggle.value = false
// FIXME: not called
// expect(calls).toEqual([
// 'root onBeforeUnmount',
// 'mid onBeforeUnmount',
// 'child onBeforeUnmount',
// 'child onUnmounted',
// 'mid onUnmounted',
// 'root onUnmounted',
// ])
ctx.app.unmount()
await nextTick()
expect(calls).toEqual([
'root onBeforeUnmount',
'mid onBeforeUnmount',
'child onBeforeUnmount',
'child onUnmounted',
'mid onUnmounted',
'root onUnmounted',
])
})

it('onRenderTracked', async () => {
Expand Down Expand Up @@ -422,12 +411,11 @@ describe('api: lifecycle hooks', () => {
})
})

it.todo('runs shared hook fn for each instance', async () => {
it('runs shared hook fn for each instance', async () => {
const fn = vi.fn()
const toggle = ref(true)
const { render } = define({
setup() {
// @ts-expect-error
return createIf(
() => toggle.value,
() => [createComponent(Child), createComponent(Child)],
Expand All @@ -446,7 +434,7 @@ describe('api: lifecycle hooks', () => {
expect(fn).toHaveBeenCalledTimes(2)
toggle.value = false
await nextTick()
// expect(fn).toHaveBeenCalledTimes(4) // FIXME: not called unmounted hook
expect(fn).toHaveBeenCalledTimes(4)
})

// #136
Expand Down
6 changes: 3 additions & 3 deletions packages/runtime-vapor/__tests__/dom/templateRef.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('api: template ref', () => {
expect(fooEl.value).toBe(null)
})

it.todo('string ref unmount', async () => {
it('string ref unmount', async () => {
const t0 = template('<div></div>')
const el = ref(null)
const toggle = ref(true)
Expand Down Expand Up @@ -153,7 +153,7 @@ describe('api: template ref', () => {
expect(fn2.mock.calls[0][0]).toBe(host.children[0])
})

it.todo('function ref unmount', async () => {
it('function ref unmount', async () => {
const fn = vi.fn()
const toggle = ref(true)

Expand Down Expand Up @@ -361,7 +361,7 @@ describe('api: template ref', () => {
})

// #1789
test.todo('toggle the same ref to different elements', async () => {
test('toggle the same ref to different elements', async () => {
const refToggle = ref(false)
const spy = vi.fn()

Expand Down
Loading